[PATCH] D52759: [AMDGPU] Rename pass "isel" to amdgpu-isel

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 2 20:41:28 PDT 2018


MaskRay added a comment.

In https://reviews.llvm.org/D52759#1253434, @arsenm wrote:

> LGTM. The pass name system here is really broken. I don't see how this would break -stop-after without building the target


Thanks. It is just that the pass name does not have a namespace... AMDGPU used the generic name "isel" which might make people confused.

If they don't build the AMDGPU target and think "isel" is a valid pass:

  % llc -stop-after=isel -o - test/CodeGen/AArch64/sdag-store-merging-bug.ll
  LLVM ERROR: "isel" pass is not registered.


Repository:
  rL LLVM

https://reviews.llvm.org/D52759





More information about the llvm-commits mailing list