[PATCH] D52799: [llvm-pdbutil] Pretty print PDBSymbolUsingNamespace symbols

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 2 13:48:23 PDT 2018


zturner added inline comments.


================
Comment at: tools/llvm-pdbutil/PrettyCompilandDumper.cpp:226
+  Printer.NewLine();
+  Printer << "usingnamespace ";
+  std::string Name = Symbol.getName();
----------------
We try to make it look like actual C++ code.  So with that in mind we should put a space between the two words and colorize them as C++ keywords.  Can you write this as:

```
WithColor(Printer, PDB_ColorItem::Keyword).get() << "using namespace ";
```



Repository:
  rL LLVM

https://reviews.llvm.org/D52799





More information about the llvm-commits mailing list