[PATCH] D35035: [InstCombine] Prevent memcpy generation for small data size

[Aditya Kumar via Phabricator via llvm-commits]

hiraditya added a comment.

In https://reviews.llvm.org/D35035#1252796, @SjoerdMeijer wrote:

> > The ultimate goal would be to simply always canonicalize to memcpy and not expand it ever in instcombine as mentioned in https://reviews.llvm.org/D52081.
>
> Looks like we all agree on this now.
>
> > But we don't do that (yet) because we're afraid of missed optimizations that can't be replicated in the backend.
>
> Perhaps the impact is negligible, non-existent, and we worry about this for nothing. As also suggested earlier, I will try to get some numbers on the table for ARM and AArch64 if we strip out the lowering here, if that is helpful for this discussion, but probably need a day or two to get them.


If you could provide some numbers, I can go ahead and remove the inlining of memcpy altogether provided the reviewers agree with it, or we can merge this patch which is trying to improve on previously hardcoded numbers.


https://reviews.llvm.org/D35035