[PATCH] D52555: [X86] Fix use SSE registers if no-x87 is selected.

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 2 10:14:27 PDT 2018


nickdesaulniers added a comment.

I've tested this patch and it fixes the cases from PR38738, and I'm happy with the code changes.  @craig.topper , would you mind reviewing, too?



================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:612
+      addLegalFPImmediate(APFloat(-1.0)); // FLD1/FCHS
+    } else 
+      addLegalFPImmediate(APFloat(+0.0)); // xorpd
----------------
Testing the raw patch file, looks like this line has trailing whitespace.  Did you mean to have a trailing comment, like L603 above?


Repository:
  rL LLVM

https://reviews.llvm.org/D52555





More information about the llvm-commits mailing list