[PATCH] D52776: [OptRemarks] Add library for parsing optimization remarks

[Francis Visoiu Mistrih via Phabricator via llvm-commits]

thegameg updated this revision to Diff 167954.
thegameg marked 6 inline comments as done.
thegameg edited the summary of this revision.
thegameg added a comment.

Thanks Jonas for the review.

- Unify the comments format.
- Use Doxygen in /lib as well.
- Add conversion function from StringRef to LLVMOptRemarkStringRef.
- Return `true` on success and `false` otherwise.
- Fix naming conventions.
- Immediately return `nullptr` if the parser had any errors.
- Check for *exactly* one remark in the unit tests. This also tests for the return value of `GetNext`.


https://reviews.llvm.org/D52776

Files:
  include/llvm-c/OptRemarks.h
  lib/CMakeLists.txt
  lib/LLVMBuild.txt
  lib/OptRemarks/CMakeLists.txt
  lib/OptRemarks/LLVMBuild.txt
  lib/OptRemarks/OptRemarksParser.cpp
  tools/llvm-opt-report/CMakeLists.txt
  tools/llvm-opt-report/OptReport.cpp
  unittests/CMakeLists.txt
  unittests/OptRemarks/CMakeLists.txt
  unittests/OptRemarks/OptRemarksParsingTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52776.167954.patch
Type: text/x-patch
Size: 39953 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181002/3953783f/attachment.bin>