[PATCH] D52747: [InstCombine] reverse 'trunc X to <N x i1>' canonicalization

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 2 07:59:15 PDT 2018


spatel added a comment.

> If we use the already extracted APInt values, we won't handle vectors with undefs because m_APInt doesn't match those (yet). 
>  So in cases like this, I've been using the more specific matcher even if it looks redundant.
>  I will add a test that includes undefs in the constant vector values.

Looking at this closer...as the patch is written currently, we would fail to match if the compare constant (zero) has undefs because we already used m_APInt as a condition to get here in the first place.


https://reviews.llvm.org/D52747





More information about the llvm-commits mailing list