[PATCH] D52744: Add support for GOT relocation support to Hexagon

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 1 13:49:55 PDT 2018


ruiu added inline comments.


================
Comment at: ELF/InputSection.cpp:549
+  case R_HEXAGON_GOT:
+    return Sym.getGotVA() - In.GotPlt->getVA();
   case R_MIPS_GOTREL:
----------------
You are not using `A` nor `P`, so this expression is a constant. Is this code correct?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D52744





More information about the llvm-commits mailing list