[PATCH] D46662: [X86] condition branches folding for three-way conditional codes

[Andrea Di Biagio via Phabricator via llvm-commits]

andreadb accepted this revision.
andreadb added a comment.
This revision is now accepted and ready to land.

Thanks.
I don’t have other comments.

I didn’t properly review the part where you fix branch probabilities. So, it would be nice if somebody else reviews that part.



================
Comment at: lib/Target/X86/X86CondBrFolding.cpp:473
+// The valid candidate will have two successors.
+// It also should should has a sequence of
+//  Brand_instr,
----------------
“should” is repeated here.


================
Comment at: lib/Target/X86/X86CondBrFolding.cpp:474
+// It also should should has a sequence of
+//  Brand_instr,
+//  CondBr,
----------------
s/brand/branch


https://reviews.llvm.org/D46662