[PATCH] D45543: [globalisel] Add a combiner helpers for extending loads and use them in a pre-legalize combiner for AArch64

[Aditya Nandakumar via Phabricator via llvm-commits]

aditya_nandakumar added inline comments.


================
Comment at: include/llvm/CodeGen/GlobalISel/Combiner.h:35
+  virtual void createdInstr(MachineInstr &MI) = 0;
+};
+
----------------
This should not be necessary any more. You can attach delegate to the machine function to observe insertions and deletions. The combiner can install a delegate at the beginning of the pass.

Do you see any other reason to have the Observer mechanism? Is there a need to rely on the maintainer scheduling order of visit or is it just to make sure of insertions and deletions?


Repository:
  rL LLVM

https://reviews.llvm.org/D45543