[PATCH] D52599: [XRay] Reduce overly broad 'rm' command in lit test

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 1 10:10:14 PDT 2018


MaskRay added a comment.

In https://reviews.llvm.org/D52599#1248882, @jmorse wrote:

> Fixed concurrently by r343282!


:)

I missed another race in the description. There are two:

- `rm` can delete files of other tests and cause them to fail
- `rm` may expand file names first but when it tries deleting them, other tests have already deleted the files and cause the test to fail.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D52599





More information about the llvm-commits mailing list