[PATCH] D52439: [InstCombine] try to convert vector insert+extract to trunc

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 1 07:49:15 PDT 2018


spatel added a comment.

In https://reviews.llvm.org/D52439#1250933, @spatel wrote:

> Reverted at https://reviews.llvm.org/rL343458 because we can create bogus trunc insts (not sure how yet).


I forgot to add a check for casting to an FP type in the original patch, so we died trying to perform an integer op on a float.
For now, I just added that check, but I think we should be able to handle patterns with FP types too, so I added a TODO comment.


Repository:
  rL LLVM

https://reviews.llvm.org/D52439





More information about the llvm-commits mailing list