[PATCH] D52149: add support functions for hard/soft float multilib distinction

Kristina Brooks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 1 04:50:28 PDT 2018


kristina added a comment.

In https://reviews.llvm.org/D52149#1250779, @rengolin wrote:

> We really shouldn't be adding code that will later be reverted just for the sake of testing other parts of the project.


As I said, that's not the intent. The intent is to allow a blocking change through that, IMHO, is extremely unlikely to start being used by other LLVM projects left and right. But anyway, since you've been a reviewer for far longer than I have and have more experience with situations like these, I'll defer to your judgement.


Repository:
  rL LLVM

https://reviews.llvm.org/D52149





More information about the llvm-commits mailing list