[PATCH] D52149: add support functions for hard/soft float multilib distinction

Kristina Brooks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 1 04:31:30 PDT 2018


kristina added a comment.

In https://reviews.llvm.org/D52149#1250753, @rengolin wrote:

> Committing a patch with the intent to revert is never a good policy.


There's no intent to revert, there's intent to make it easier for Clang reviewers to not have to apply separate patchsets from LLVMSupport and from the Clang diff. The intent is to allow it to stay until the Clang diff is reviewed and **then** if it's not accepted, revert the now-unused chunk of code. Anyway, once it's fixed, I'm personally in favor and think this does belong in `Triple`, but it looks like the consensus is going to be against.


Repository:
  rL LLVM

https://reviews.llvm.org/D52149





More information about the llvm-commits mailing list