[PATCH] D52668: [DAGCombiner] Improve X div/rem Y fold if single bit element type

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 30 07:03:19 PDT 2018


spatel added inline comments.


================
Comment at: test/CodeGen/Mips/llvm-ir/urem.ll:40-43
+; GP32-NEXT:    .set at
+; GP32-NEXT:    .set macro
+; GP32-NEXT:    .set reorder
+; GP32-NEXT:    .end urem_i1
----------------
All of this non-code output suggests that:
1. We need to refine the script for MIPS asm.
2. You might want to just hand-edit the existing test(s) where your patch makes a difference.

If you do want to auto-gen the checks for this file, that should be done before this patch in a NFC commit.


https://reviews.llvm.org/D52668





More information about the llvm-commits mailing list