[PATCH] D52698: Revert r330966: Replace SharedSymbols with Defined when creating copy relocations.

Orivej Desh via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 29 16:35:23 PDT 2018


orivej created this revision.
orivej added reviewers: ruiu, grimar, espindola.
Herald added subscribers: llvm-commits, arichardson, emaste.

This revert has one meaningful change in `getSymSectionIndex` in `ELF/SyntheticSections.cpp`: if `Sym->getOutputSection()` is not null, it should take priority over `isa<Defined>` check, as it did before r338247 (https://reviews.llvm.org/D49541).

Fixes https://bugs.llvm.org/show_bug.cgi?id=39104

TODO: add a test case.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D52698

Files:
  ELF/LinkerScript.cpp
  ELF/MapFile.cpp
  ELF/Relocations.cpp
  ELF/Symbols.cpp
  ELF/Symbols.h
  ELF/SyntheticSections.cpp
  ELF/SyntheticSections.h
  ELF/Writer.cpp
  test/ELF/map-file.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52698.167629.patch
Type: text/x-patch
Size: 13412 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180929/26b1493f/attachment.bin>


More information about the llvm-commits mailing list