[PATCH] D52324: [ValueTracking] Allow select patterns to work on vectors in more places

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 28 14:01:37 PDT 2018


aheejin accepted this revision.
aheejin added a comment.
This revision is now accepted and ready to land.

If this CL only handles floating point vectors and not integer vectors, I don't think that's a job of this CL to implement the integer part as well, but maybe it's better to add a line of comment that's marked as TODO saying currently in case of vectors only floating points are supported, or something. Otherwise LGTM.


Repository:
  rL LLVM

https://reviews.llvm.org/D52324





More information about the llvm-commits mailing list