[PATCH] D52636: GraphWriter: Provide an API for writing a graph into a specified file

[George Karpenkov via Phabricator via llvm-commits]

george.karpenkov added inline comments.


================
Comment at: llvm/include/llvm/Support/GraphWriter.h:339
+      llvm::errs() << "error writing into file" << "\n";
+      return "";
+    }
----------------
NoQ wrote:
> This function returns `Filename` on the success branch, should we pass it through here as well?
This is an error branch. Later on we also return an empty string in case of an error.


https://reviews.llvm.org/D52636