[PATCH] D52548: Stop instcombining propagating wider shufflevector arguments to predecessors.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 28 06:37:46 PDT 2018


lebedev.ri added inline comments.


================
Comment at: include/llvm/IR/Instructions.h:2460
   /// elements than its source vectors.
   /// Example: shufflevector <4 x n> A, <4 x n> B, <1,2>
   bool changesLength() const {
----------------
sheredom wrote:
> lebedev.ri wrote:
> > ```
> >   /// Examples: shufflevector <4 x n> A, <4 x n> B, <1,2,3>
> >   ///           shufflevector <4 x n> A, <4 x n> B, <1,2,3,4,5>
> > ```
> You want me to change the comment of the function I didn't touch? I generally try and avoid doing that, but if you think it is worth it I can!
Yes, i think that comment for a slightly related function should be updated.


Repository:
  rL LLVM

https://reviews.llvm.org/D52548





More information about the llvm-commits mailing list