[PATCH] D52635: [FunctionAttrs] Re-enable propagation of nonnull argument attributes from callsites to callers

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 28 06:25:03 PDT 2018


spatel added a comment.

In https://reviews.llvm.org/D52635#1248976, @xbolva00 wrote:

> Btw, cannot we just drop nonnull arg info (which we get from libc annotations) related to problematic functions (like memcpy, strncmp,..) ?
>
> And then we can mark these function args "safely" at callsites.


I don't understand all of the details, so I recommend reviving https://reviews.llvm.org/D30806 or the dev-thread that led to it to discuss further how to proceed with this patch.
You might also be interested in applying/commandeering https://reviews.llvm.org/D29999 and chasing down how it broke everything. :)


https://reviews.llvm.org/D52635





More information about the llvm-commits mailing list