[PATCH] D52644: [ARM] Prevent DSP and SIM32 being set for v6m

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 28 02:36:39 PDT 2018


dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

LGTM, Thanks



================
Comment at: lib/Basic/Targets/ARM.cpp:666
   // ACLE 6.4.9 32-bit SIMD instructions
-  if (ArchVersion >= 6 || (CPUProfile == "M" && DSP))
+  if ((ArchVersion >= 6 && CPUProfile != "M") || (CPUProfile == "M" && DSP))
     Builder.defineMacro("__ARM_FEATURE_SIMD32", "1");
----------------
Maybe always put the CPUProfile first? so
(CPUProfile != "M" && ArchVersion >= 6) || (CPUProfile == "M" && DSP)
Up to you.


https://reviews.llvm.org/D52644





More information about the llvm-commits mailing list