[PATCH] D52548: Stop instcombining introducing undef's in div/rem instructions.

Neil Henning via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 28 01:59:54 PDT 2018


sheredom added inline comments.


================
Comment at: test/Transforms/InstCombine/stop_bad_undef_propagation.ll:4
 
-; For each of the div/rem integer instructions we test 3 different variants for
-; how an undef value could be back propagated:
----------------
lebedev.ri wrote:
> Is it intentional that the test coverage changes?
Aye - @spatel noted that what I was testing was actually a specific part of a wider problem (that we shouldn't be widening shuffle vector predecessors), so I decided to reduce the test case as a result. With my change **any** predecessor of a shuffle vector that widens the input will not be optimized in this fashion.


https://reviews.llvm.org/D52548





More information about the llvm-commits mailing list