[PATCH] D52642: [MCA] Remove SM.hasNext() call in FetchStage::execute.

Owen Rodley via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 27 22:31:22 PDT 2018


orodley created this revision.
Herald added subscribers: llvm-commits, gbedwell.
Herald added a reviewer: andreadb.

This is redundant, as FetchStage::getNextInstruction already checks this
and returns llvm::ErrorSuccess() as appropriate.

NFC.


Repository:
  rL LLVM

https://reviews.llvm.org/D52642

Files:
  llvm/tools/llvm-mca/lib/Stages/FetchStage.cpp


Index: llvm/tools/llvm-mca/lib/Stages/FetchStage.cpp
===================================================================
--- llvm/tools/llvm-mca/lib/Stages/FetchStage.cpp
+++ llvm/tools/llvm-mca/lib/Stages/FetchStage.cpp
@@ -60,7 +60,7 @@
 }
 
 llvm::Error FetchStage::cycleStart() {
-  if (!CurrentInstruction && SM.hasNext())
+  if (!CurrentInstruction)
     return getNextInstruction();
   return llvm::ErrorSuccess();
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52642.167432.patch
Type: text/x-patch
Size: 425 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180928/a383bbec/attachment.bin>


More information about the llvm-commits mailing list