[PATCH] D52639: [XRay] Guard local variables with `static` and struct with unnamed namespaces

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 27 19:12:36 PDT 2018


MaskRay added a comment.

In https://reviews.llvm.org/D52639#1248743, @dberris wrote:

> LGTM -- thanks! Is there a way for us to catch these with tests?


I'm not sure if ODRHash or other tools can catch this... This may not matter too much for a trivial type like this.. If it were virtual or had constructors, the linker would error.


Repository:
  rL LLVM

https://reviews.llvm.org/D52639





More information about the llvm-commits mailing list