[PATCH] D52450: [Intrinsic] Add llvm.minnan and llvm.maxnan instrinsic functions

[Thomas Lively via Phabricator via llvm-commits]

tlively added a comment.

In https://reviews.llvm.org/D52450#1248683, @sunfish wrote:

> Oh, right. So in that case, the existing minnum/maxnum intrinsics do have the same problem. That's probably not easy to fix, because it would require changes to existing implementations on other platforms. So we may have to add wasm-specific versions of these intrinsics after all :-/.


I don't think adding new intrinsics necessarily means we need to change anything about the old intrinsics. A the C language level, we won't expose builtin functions for wasm that lower to minnum or maxnum, since those don't match wasm semantics. To prevent people from assuming that the only difference between minnum/maxnum and the new intrinsics is NaN propagation, I propose we name the new instrinsics minimum/maximum (after the new IEEE operations) rather than minnan/maxnan.


Repository:
  rL LLVM

https://reviews.llvm.org/D52450