[PATCH] D52324: [ValueTracking] Allow select patterns to work on vectors in more places

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 27 16:18:32 PDT 2018


aheejin added inline comments.


================
Comment at: unittests/Analysis/ValueTrackingTest.cpp:163
+  // pattern.
+  expectPattern({SPF_FMINNUM, SPNB_RETURNS_NAN, false});
+}
----------------
tlively wrote:
> aheejin wrote:
> > How is the third argument `Ordered` determined?
> By the comparison operator. For example, here `ule` is unordered.
I thought so first, but other existing test cases don’t seem to follow that rule. So I was wondering if it means something else.


Repository:
  rL LLVM

https://reviews.llvm.org/D52324





More information about the llvm-commits mailing list