[llvm] r343254 - AMDGPU/NFC: Simplify VOP_MAC_F16/F32

Konstantin Zhuravlyov via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 27 12:24:05 PDT 2018


Author: kzhuravl
Date: Thu Sep 27 12:24:05 2018
New Revision: 343254

URL: http://llvm.org/viewvc/llvm-project?rev=343254&view=rev
Log:
AMDGPU/NFC: Simplify VOP_MAC_F16/F32

Modified:
    llvm/trunk/lib/Target/AMDGPU/VOP2Instructions.td

Modified: llvm/trunk/lib/Target/AMDGPU/VOP2Instructions.td
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AMDGPU/VOP2Instructions.td?rev=343254&r1=343253&r2=343254&view=diff
==============================================================================
--- llvm/trunk/lib/Target/AMDGPU/VOP2Instructions.td (original)
+++ llvm/trunk/lib/Target/AMDGPU/VOP2Instructions.td Thu Sep 27 12:24:05 2018
@@ -234,17 +234,8 @@ class VOP_MAC <ValueType vt> : VOPProfil
   let HasSDWA9 = 0;
 }
 
-def VOP_MAC_F16 : VOP_MAC <f16> {
-  // FIXME: Move 'Asm64' definition to VOP_MAC, and use 'vt'. Currently it gives
-  // 'not a string initializer' error.
-  let Asm64 = getAsm64<1, 2, 0, HasModifiers, HasOMod, f16>.ret;
-}
-
-def VOP_MAC_F32 : VOP_MAC <f32> {
-  // FIXME: Move 'Asm64' definition to VOP_MAC, and use 'vt'. Currently it gives
-  // 'not a string initializer' error.
-  let Asm64 = getAsm64<1, 2, 0, HasModifiers, HasOMod, f32>.ret;
-}
+def VOP_MAC_F16 : VOP_MAC <f16>;
+def VOP_MAC_F32 : VOP_MAC <f32>;
 
 // Write out to vcc or arbitrary SGPR.
 def VOP2b_I32_I1_I32_I32 : VOPProfile<[i32, i32, i32, untyped]> {




More information about the llvm-commits mailing list