[PATCH] D52430: Introduce a flag to warn when IFUNC symbols are used with text relocations.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Looks like this patch lacks a change you made to Options.td.

I'm sorry to be nitpicky, but maybe you should take a bit more time to review your code yourself, so that I don't have. :)



================
Comment at: ELF/Relocations.cpp:990
+          "you, consider recompiling the object files without -fPIC and "
+          "without '-Wl,-z,notext' option. Use -no-warn-ifunc-textrel to "
+          "turn off this warning." + getLocation(Sec, Sym, Offset));
----------------
Please be consistent -- you do not -fPIC with single quotes, so you shouldn't do that for -Wl,-z,-notext.


================
Comment at: docs/ld.lld.1:433
+Warn about using ifunc symbols in conjunction with text relocations.
+Older versions of glibc library (2.28 and before), has a bug that causes
+the segment that includes ifunc symbols to be marked as not executable when
----------------
2.28 and before -> 2.28 or earlier

Remove "," after ")".


================
Comment at: docs/ld.lld.1:440
+an older glibc version. Otherwise, there is no need to use it, as the default
+value does not give a warning. This flag has been introduced in late 2018, 
+has no counter part in ld and gold linkers, and may be removed in the future.
----------------
Remove the trailing whitespace.



Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D52430