[compiler-rt] r343245 - [compiler-rt] [builtins] Restore tests from r342917 (disabled in r343095) on Windows.

[Jordan Rupprecht via llvm-commits]

Author: rupprecht
Date: Thu Sep 27 11:13:01 2018
New Revision: 343245

URL: http://llvm.org/viewvc/llvm-project?rev=343245&view=rev
Log:
[compiler-rt] [builtins] Restore tests from r342917 (disabled in r343095) on Windows.

Summary:
-lm is needed for these tests on Linux, but the lit config for this package automatically adds it for Linux and excludes it for Windows. So we should be able to get these tests running again by just dropping -lm and let the lit config add it when possible.

I was under the impression that -lm worked across platforms because it exists in other tests without and 'UNSUPPORTED: windows' commands (e.g. divsc3_test.c), but those are actually excluded because they 'REQUIRES: c99-complex' which is excluded from windows platforms (also by the local lit config).

I don't have easy access to a windows machine to verify this patch, but I can trigger a build bot run on clang-x64-ninja-win7 shortly after submitting.

Reviewers: hans

Subscribers: dberris, delcypher, llvm-commits, #sanitizers

Differential Revision: https://reviews.llvm.org/D52563

Modified:
    compiler-rt/trunk/test/builtins/Unit/compiler_rt_logb_test.c
    compiler-rt/trunk/test/builtins/Unit/compiler_rt_logbf_test.c
    compiler-rt/trunk/test/builtins/Unit/compiler_rt_logbl_test.c

Modified: compiler-rt/trunk/test/builtins/Unit/compiler_rt_logb_test.c
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/builtins/Unit/compiler_rt_logb_test.c?rev=343245&r1=343244&r2=343245&view=diff
==============================================================================
--- compiler-rt/trunk/test/builtins/Unit/compiler_rt_logb_test.c (original)
+++ compiler-rt/trunk/test/builtins/Unit/compiler_rt_logb_test.c Thu Sep 27 11:13:01 2018
@@ -1,6 +1,4 @@
-// Linking with -lm won't work on Windows.
-// UNSUPPORTED: windows
-// RUN: %clang_builtins %s %librt -lm -o %t && %run %t
+// RUN: %clang_builtins %s %librt -o %t && %run %t
 //===-- compiler_rt_logb_test.c - Test __compiler_rt_logb -----------------===//
 //
 //                     The LLVM Compiler Infrastructure

Modified: compiler-rt/trunk/test/builtins/Unit/compiler_rt_logbf_test.c
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/builtins/Unit/compiler_rt_logbf_test.c?rev=343245&r1=343244&r2=343245&view=diff
==============================================================================
--- compiler-rt/trunk/test/builtins/Unit/compiler_rt_logbf_test.c (original)
+++ compiler-rt/trunk/test/builtins/Unit/compiler_rt_logbf_test.c Thu Sep 27 11:13:01 2018
@@ -1,6 +1,4 @@
-// Linking with -lm won't work on Windows.
-// UNSUPPORTED: windows
-// RUN: %clang_builtins %s %librt -lm -o %t && %run %t
+// RUN: %clang_builtins %s %librt -o %t && %run %t
 //===-- compiler_rt_logbf_test.c - Test __compiler_rt_logbf ---------------===//
 //
 //                     The LLVM Compiler Infrastructure

Modified: compiler-rt/trunk/test/builtins/Unit/compiler_rt_logbl_test.c
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/builtins/Unit/compiler_rt_logbl_test.c?rev=343245&r1=343244&r2=343245&view=diff
==============================================================================
--- compiler-rt/trunk/test/builtins/Unit/compiler_rt_logbl_test.c (original)
+++ compiler-rt/trunk/test/builtins/Unit/compiler_rt_logbl_test.c Thu Sep 27 11:13:01 2018
@@ -1,6 +1,4 @@
-// Linking with -lm won't work on Windows.
-// UNSUPPORTED: windows
-// RUN: %clang_builtins %s %librt -lm -o %t && %run %t
+// RUN: %clang_builtins %s %librt -o %t && %run %t
 //===-- compiler_rt_logbl_test.c - Test __compiler_rt_logbl ---------------===//
 //
 //                     The LLVM Compiler Infrastructure