[PATCH] D52597: [XRay] Add LD_LIBRARY_PATH to env variables for Unit Tests

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 27 10:36:38 PDT 2018


dberris added inline comments.


================
Comment at: compiler-rt/lib/xray/tests/CMakeLists.txt:74
+  append_list_if(COMPILER_RT_HAS_LIBM -lm XRAY_UNITTEST_LINK_FLAGS)
+  append_list_if(COMPILER_RT_HAS_LIBRT -lrt XRAY_UNITTEST_LINK_FLAGS)
+  append_list_if(COMPILER_RT_HAS_LIBDL -ldl XRAY_UNITTEST_LINK_FLAGS)
----------------
MaskRay wrote:
> Does xray unittests call `clock_*` `timer_*` `mq_*` that are provided by librt?
> http://refspecs.linuxbase.org/LSB_5.0.0/LSB-Core-generic/LSB-Core-generic/librt.html
> 
> 
Yes -- is that going to be a problem?


https://reviews.llvm.org/D52597





More information about the llvm-commits mailing list