[PATCH] D52540: Fix an ordering bug in the scalarizer.

[Mikael Holmén via Phabricator via llvm-commits]

uabelho added a comment.

In https://reviews.llvm.org/D52540#1247778, @sheredom wrote:

> In https://reviews.llvm.org/D52540#1247681, @uabelho wrote:
>
> > Is this the same problem as described in https://bugs.llvm.org/show_bug.cgi?id=28911 ?
>
>
> I wasn't seeing the exact same failure as that bug describes - it was failing in Scalarizer::finish in the test included.
>
> But I did pull the example from the bugzilla and tested it and it no longer crashes with my scalarizer fix.


I don't know the Scalarizer but from the descriptions of the problems I think it sounds like they are similar or the same,
and if so, there are then two possible solutions.

dstenb described a possible fix in a comment of PR28911 and we've been using that fix for a long time now for our
out-of-tree target without problems.

Perhaps that fix is a hack and using RPOT is the proper way to deal with this, I've no idea. I just wanted to point out the
possibility.

Anyway, I applied the fix in this patch on our local tree and so far so good so I don't have any objections, but I don't
really know the code enough to say it's the right thing to do.


Repository:
  rL LLVM

https://reviews.llvm.org/D52540