[PATCH] D52570: [X86] Don't generate BMI BEXTR from X86DAGToDAGISel::matchBEXTRFromAnd

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

Can we come up with a slightly better logic rather than just `haveTBM()`?
Else, i'm not sure how to fix https://reviews.llvm.org/D52293 / PR38938 <https://bugs.llvm.org/show_bug.cgi?id=38938>.
Can we perhaps also allow cases when we are shifting a `load`?



================
Comment at: lib/Target/X86/X86ISelDAGToDAG.cpp:2598
+  // hoisting the move immediate would make it worthwhile?
+  if (!Subtarget->hasTBM())
     return false;
----------------
I think we are also missing a check that NVT is not i64 if we are in 32-bit mode.


https://reviews.llvm.org/D52570