[PATCH] D50902: [compiler-rt][ubsan] Split Implicit Integer Truncation Sanitizer into unsigned and signed checks

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 27 02:28:19 PDT 2018


lebedev.ri added inline comments.


================
Comment at: test/ubsan/TestCases/ImplicitConversion/integer-truncation.c:96
+unsigned int convert_signed_char_to_unsigned_int(signed char x) {
+#line 1400
+  return x;
----------------
lebedev.ri wrote:
> vitalybuka wrote:
> > Could you please split refactoring and behavior changes into separate patches?
> I'm not sure i follow.
> By refactoring you mean the test rewrite?
Hopefully this is better.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D50902





More information about the llvm-commits mailing list