[PATCH] D52475: [AArch64][v8.5A] Add FRINT[32,64][Z,X] instructions

Oliver Stannard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 27 02:28:17 PDT 2018


olista01 added inline comments.


================
Comment at: lib/Target/AArch64/AArch64InstrInfo.td:67
                        AssemblerPredicate<"FeatureAltFPCmp", "altnzcv">;
+def HasFRIntNNT      : Predicate<"Subtarget->hasFRIntNNT()">,
+                       AssemblerPredicate<"FeatureFRIntNNT", "fptoint">;
----------------
t.p.northover wrote:
> What's behind the "NNT" here? It's not a particularly obvious name.
I've asked Pablo (who originally wrote this patch) and he can't remember what it stands for, so I agree we should change it so something more meaningful. How about HasFRInt3264?


Repository:
  rL LLVM

https://reviews.llvm.org/D52475





More information about the llvm-commits mailing list