[compiler-rt] r343178 - [Coverage] Disable Linux/coverage-missing.cc in AddressSanitizer-i386-linux testsuite

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 26 23:37:15 PDT 2018


Author: maskray
Date: Wed Sep 26 23:37:15 2018
New Revision: 343178

URL: http://llvm.org/viewvc/llvm-project?rev=343178&view=rev
Log:
[Coverage] Disable Linux/coverage-missing.cc in AddressSanitizer-i386-linux testsuite

sancov.py relies on objdump -d to obtain the number of instrumented PCs.
The i386 %dynamiclib will now include .plt entries that are not recognized by objdump,

"sancov.py: found 0 instrumented PCs in *.so",

causing AddressSanitizer-i386-linux to fail.

Change it back to x86-target-arch after %sancov switches to a more robust approach.

Modified:
    compiler-rt/trunk/test/asan/TestCases/Linux/coverage-missing.cc

Modified: compiler-rt/trunk/test/asan/TestCases/Linux/coverage-missing.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Linux/coverage-missing.cc?rev=343178&r1=343177&r2=343178&view=diff
==============================================================================
--- compiler-rt/trunk/test/asan/TestCases/Linux/coverage-missing.cc (original)
+++ compiler-rt/trunk/test/asan/TestCases/Linux/coverage-missing.cc Wed Sep 26 23:37:15 2018
@@ -45,7 +45,15 @@
 // RUN: diff bar.txt foo-missing.txt > %t.log || true
 // RUN: not grep "^<" %t.log
 
-// REQUIRES: x86-target-arch
+// FIXME %sancov GetInstrumentedPCs relies on objdump -d to
+// obtain the number of instrumented PCs.  The i386
+// %dynamiclib has .plt entries that are not recognized by
+// objdump,
+// "sancov.py: found 0 instrumented PCs in *.so",
+// causing AddressSanitizer-i386-linux to fail.
+// Change it back to x86-target-arch after %sancov switches to a more robust approach.
+
+// REQUIRES: x86_64-target-arch
 // XFAIL: android
 
 #include <stdio.h>




More information about the llvm-commits mailing list