[llvm] r343154 - [WebAssembly] Fix MRI.hasOneNonDBGUse assert in WebAssemblyRegStackify pass

Yury Delendik via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 26 16:49:21 PDT 2018


Author: yurydelendik
Date: Wed Sep 26 16:49:21 2018
New Revision: 343154

URL: http://llvm.org/viewvc/llvm-project?rev=343154&view=rev
Log:
[WebAssembly] Fix MRI.hasOneNonDBGUse assert in WebAssemblyRegStackify pass 

Summary:
The OneUseDominatesOtherUses in the WebAssemblyRegStackify not properly validates register use using hasOneUse. Since we added/modified DBG_VALUE the assert started catching valid cases.

See also https://reviews.llvm.org/D49034#1247200

Fix verified by running the wasm waterfall.

Reviewed By: dschuff

Tags: #debug-info

Differential Revision: https://reviews.llvm.org/D49034

Modified:
    llvm/trunk/lib/Target/WebAssembly/WebAssemblyRegStackify.cpp

Modified: llvm/trunk/lib/Target/WebAssembly/WebAssemblyRegStackify.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/WebAssembly/WebAssemblyRegStackify.cpp?rev=343154&r1=343153&r2=343154&view=diff
==============================================================================
--- llvm/trunk/lib/Target/WebAssembly/WebAssemblyRegStackify.cpp (original)
+++ llvm/trunk/lib/Target/WebAssembly/WebAssemblyRegStackify.cpp Wed Sep 26 16:49:21 2018
@@ -428,8 +428,8 @@ static bool OneUseDominatesOtherUses(uns
         if (!TargetRegisterInfo::isVirtualRegister(DefReg) ||
             !MFI.isVRegStackified(DefReg))
           return false;
-        assert(MRI.hasOneUse(DefReg));
-        const MachineOperand &NewUse = *MRI.use_begin(DefReg);
+        assert(MRI.hasOneNonDBGUse(DefReg));
+        const MachineOperand &NewUse = *MRI.use_nodbg_begin(DefReg);
         const MachineInstr *NewUseInst = NewUse.getParent();
         if (NewUseInst == OneUseInst) {
           if (&OneUse > &NewUse)




More information about the llvm-commits mailing list