[PATCH] D52563: [compiler-rt] [builtins] Restore tests from r342917 (disabled in r343095) on Windows.

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht created this revision.
rupprecht added a reviewer: hans.
Herald added subscribers: Sanitizers, llvm-commits, delcypher, dberris.
rupprecht edited the summary of this revision.

-lm is needed for these tests on Linux, but the lit config for this package automatically adds it for Linux and excludes it for Windows. So we should be able to get these tests running again by just dropping -lm and let the lit config add it when possible.

I was under the impression that -lm worked across platforms because it exists in other tests without any 'UNSUPPORTED: windows' commands (e.g. see divsc3_test.c), but those are actually excluded because they 'REQUIRES: c99-complex' which is excluded from windows platforms (also by the local lit config).

I don't have easy access to a windows machine to verify this patch, but I can trigger a build bot run on clang-x64-ninja-win7 shortly after submitting.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D52563

Files:
  test/builtins/Unit/compiler_rt_logb_test.c
  test/builtins/Unit/compiler_rt_logbf_test.c
  test/builtins/Unit/compiler_rt_logbl_test.c


Index: test/builtins/Unit/compiler_rt_logbl_test.c
===================================================================
--- test/builtins/Unit/compiler_rt_logbl_test.c
+++ test/builtins/Unit/compiler_rt_logbl_test.c
@@ -1,6 +1,4 @@
-// Linking with -lm won't work on Windows.
-// UNSUPPORTED: windows
-// RUN: %clang_builtins %s %librt -lm -o %t && %run %t
+// RUN: %clang_builtins %s %librt -o %t && %run %t
 //===-- compiler_rt_logbl_test.c - Test __compiler_rt_logbl ---------------===//
 //
 //                     The LLVM Compiler Infrastructure
Index: test/builtins/Unit/compiler_rt_logbf_test.c
===================================================================
--- test/builtins/Unit/compiler_rt_logbf_test.c
+++ test/builtins/Unit/compiler_rt_logbf_test.c
@@ -1,6 +1,4 @@
-// Linking with -lm won't work on Windows.
-// UNSUPPORTED: windows
-// RUN: %clang_builtins %s %librt -lm -o %t && %run %t
+// RUN: %clang_builtins %s %librt -o %t && %run %t
 //===-- compiler_rt_logbf_test.c - Test __compiler_rt_logbf ---------------===//
 //
 //                     The LLVM Compiler Infrastructure
Index: test/builtins/Unit/compiler_rt_logb_test.c
===================================================================
--- test/builtins/Unit/compiler_rt_logb_test.c
+++ test/builtins/Unit/compiler_rt_logb_test.c
@@ -1,6 +1,4 @@
-// Linking with -lm won't work on Windows.
-// UNSUPPORTED: windows
-// RUN: %clang_builtins %s %librt -lm -o %t && %run %t
+// RUN: %clang_builtins %s %librt -o %t && %run %t
 //===-- compiler_rt_logb_test.c - Test __compiler_rt_logb -----------------===//
 //
 //                     The LLVM Compiler Infrastructure


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52563.167163.patch
Type: text/x-patch
Size: 1650 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180926/a3d53a2a/attachment.bin>