[PATCH] D52537: Ignore dropped call operands when allocating MD slot numbers

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a subscriber: hfinkel.
vsk added a comment.

Thanks for the patch. The change to SlotTracker looks safe to me. I do think it's the cleanest way to address the kind of crash you're seeing -- as I pointed out in the PR, modifying BDCE to eagerly erase dead instructions may not go well. @hfinkel, any thoughts on this?

As for the test, I think a unit test might work better (see unittests/IR/MetadataTest.cpp). If something about debug info or BDCE changes, the test will remain useful. [Could be worth waiting for Duncan or Hal to approve the SlotTracker change before updating the patch.]


Repository:
  rL LLVM

https://reviews.llvm.org/D52537