[PATCH] D52473: [AArch64][v8.5A] Add PSTATE manipulation instructions XAFlag and AXFlag

Tim Northover via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 26 08:01:00 PDT 2018


t.p.northover added inline comments.


================
Comment at: lib/Target/AArch64/AArch64InstrInfo.td:615
+
+def XAFLAG : PstateWriteSimple<(ins), "xaflag", "">, Sched<[WriteSys]> {
+  let Inst{18-16} = 0b000;
----------------
I think these should be marked as Uses and Defs NZCV. I know you're only really doing assembly at the moment, but it's something that could very easily be overlooked later.


Repository:
  rL LLVM

https://reviews.llvm.org/D52473





More information about the llvm-commits mailing list