[PATCH] D52553: [PHIElimination] Update the regression test for PR16508

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope created this revision.
Herald added subscribers: jsji, nemanjai.

When PR16508 was solved (in https://reviews.llvm.org/rL185363) a regression test was
added as test/CodeGen/PowerPC/2013-07-01-PHIElimBug.ll.
I discovered that the test case no longer reproduced the
scenario from PR16508. This problem was amended by adding
an extra RUN line with "-O1".

I also added a mir-reproducer

  test/CodeGen/PowerPC/2013-07-01-PHIElimBug.mir

to get a reproducer that is less sensitive to changes in
earlier passes (including O-level).

While being at it I also corrected a code comment in
PHIElimination::EliminatePHINodes that has been incorrect
since the related bugfix from https://reviews.llvm.org/rL185363.


Repository:
  rL LLVM

https://reviews.llvm.org/D52553

Files:
  lib/CodeGen/PHIElimination.cpp
  test/CodeGen/PowerPC/2013-07-01-PHIElimBug.ll
  test/CodeGen/PowerPC/2013-07-01-PHIElimBug.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52553.167137.patch
Type: text/x-patch
Size: 4650 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180926/54d6431f/attachment.bin>