[PATCH] D52279: [sanitizer] Make __sanitizer::CheckFailed not public

Kostya Kortchinsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 26 07:53:32 PDT 2018


cryptoad added a comment.

In https://reviews.llvm.org/D52279#1246222, @mstorsjo wrote:

> Should we revert this again, or readd the attribute for windows builds only?


I am not familiar at all with the logic there, I can re-add it for Windows unless someone else has a better idea (maybe `__i386__` only too)?


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D52279





More information about the llvm-commits mailing list