[PATCH] D52430: Introduce a flag to warn when IFUNC symbols are used with text relocations.

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

In https://reviews.llvm.org/D52430#1245927, @tamur wrote:

> > The other way to print out that error message is to make it more brief and include a URL to explain the issue, like this:
> > 
> >   error: IFUNC symbols and text relocations are not allowed. For more info, see http://lld.llvm.org/ifunc-textrel
>
> I have no opinion whether this would be a good idea, but looking at the web site, there does not seem to be any precedent?


I believe there was no any precedent yet.

In https://reviews.llvm.org/D52430#1245899, @ruiu wrote:

> That error message is displayed in one line, and usually error messages are not that long. And still the error message does not contain enough information about the warning. The other way to print out that error message is to make it more brief and include a URL to explain the issue, like this:
>
>   error: IFUNC symbols and text relocations are not allowed. For more info, see http://lld.llvm.org/ifunc-textrel
>   
>
> I feel this is better than a long error message, as we can explain the issue on the website.
>
> What do you think? What other people think?


The benefit from this that we can track and update the status of the fix and even maybe provide info about the known distributions affected/fixed
on the page what can be helpful for removing this flag at some longer-term point.

At the same time, I am not sure if we have other unobvious errors that might need the additional explanation. I guess this will be the only error referring to some URL,
what looks a bit inconsistent.

Another point is that perhaps it is the first flag we introduce knowing we will want to remove it. And perhaps having a page saying "it was introduced in LLD vX and removed in vY"
would be useful at some point.

I am not sure how the transaction (the removing of the flag) will happen though. There is nothing more permanent than temporary and simple
removing the flag can break some builds I think. Though forcing doing that would be the right thing still.

Given all the above I think having URL where we can post status updates is at least sound reasonable.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D52430