committing a change to llvm

Zakharin, Vyacheslav P via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 25 16:33:23 PDT 2018


Thank you, Eli! I'd better subscribe to llvm-commits then...

Thanks,
Slava

From: Friedman, Eli [mailto:efriedma at codeaurora.org]
Sent: Tuesday, September 25, 2018 4:27 PM
To: Zakharin, Vyacheslav P <vyacheslav.p.zakharin at intel.com>; llvm-commits at lists.llvm.org
Subject: Re: committing a change to llvm

On 9/25/2018 11:28 AM, Zakharin, Vyacheslav P via llvm-commits wrote:
Hello,

I have https://reviews.llvm.org/D52176 accepted in Phabricator, and I want to commit it.  LLVM Developer Policy doc says that "To get approval, submit a patch to llvm-commits.  When approved, you may commit it yourself."

Am I supposed to submit the patch to llvm-commits in addition to having it reviewed in Phabricator?


Your patch was already approved on llvm-commits: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20180917/587981.html .  (llvm-commits is a subscriber for that review, so the patch and all the review comments were sent to llvm-commits.)

-Eli


--

Employee of Qualcomm Innovation Center, Inc.

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180925/b38936fe/attachment.html>


More information about the llvm-commits mailing list