[PATCH] D52470: [ARM/AArch64][v8.5A] Add Armv8.5-A target

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: lib/Target/ARM/ARM.td:456
+def HasV8_5aOps   : SubtargetFeature<"v8.5a", "HasV8_5aOps", "true",
+                                   "Support Armv8.5-A instructions",
+                                   [HasV8_4aOps]>;
----------------
Is this intentionally diffferent to the 8.4 and aarch64 8.5 strings?


================
Comment at: unittests/Support/TargetParserTest.cpp:29
+    "armv8l",      "armv8.1-a",    "armv8.1a",    "armv8.2-a",    "armv8.2a",
+    "armv8.3-a",   "armv8.3a",     "armv8.5-a",   "armv8.5a",     "armv8-r",
+    "armv8r",      "armv8-m.base", "armv8m.base", "armv8-m.main", "armv8m.main",
----------------
Should this not all include 8.4?


Repository:
  rL LLVM

https://reviews.llvm.org/D52470