[PATCH] D52518: AMDGPU: Add Selection patterns to support add of one bit.

[Changpeng Fang via Phabricator via llvm-commits]

cfang created this revision.
cfang added a reviewer: rampitec.
Herald added subscribers: t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng, jvesely, kzhuravl.

We generate s_xor to lower add of i1s in general cases, and s_not to lower add with a one-bit imm of -1 (true).


https://reviews.llvm.org/D52518

Files:
  lib/Target/AMDGPU/SIInstructions.td
  test/CodeGen/AMDGPU/add_i1.ll


Index: test/CodeGen/AMDGPU/add_i1.ll
===================================================================
--- /dev/null
+++ test/CodeGen/AMDGPU/add_i1.ll
@@ -0,0 +1,21 @@
+; RUN: llc -march=amdgcn -mcpu=gfx900 -verify-machineinstrs < %s | FileCheck -check-prefix=GCN %s
+
+
+; GCN-LABEL: {{^}}add_var_var_i1:
+; GCN: s_xor_b64
+define amdgpu_kernel void @add_var_var_i1(i1 addrspace(1)* %out, i1 addrspace(1)* %in0, i1 addrspace(1)* %in1) {
+  %a = load volatile i1, i1 addrspace(1)* %in0
+  %b = load volatile i1, i1 addrspace(1)* %in1
+  %add = add i1 %a, %b
+  store i1 %add, i1 addrspace(1)* %out
+  ret void
+}
+
+; GCN-LABEL: {{^}}add_var_imm_i1:
+; GCN: s_not_b64
+define amdgpu_kernel void @add_var_imm_i1(i1 addrspace(1)* %out, i1 addrspace(1)* %in) {
+  %a = load volatile i1, i1 addrspace(1)* %in
+  %add = add i1 %a, 1
+  store i1 %add, i1 addrspace(1)* %out
+  ret void
+}
Index: lib/Target/AMDGPU/SIInstructions.td
===================================================================
--- lib/Target/AMDGPU/SIInstructions.td
+++ lib/Target/AMDGPU/SIInstructions.td
@@ -1323,6 +1323,18 @@
 >;
 
 def : GCNPat <
+  (i1 (add i1:$src0, i1:$src1)),
+  (S_XOR_B64 $src0, $src1)
+>;
+
+let AddedComplexity = 1 in {
+def : GCNPat <
+  (i1 (add i1:$src0, (i1 -1))),
+  (S_NOT_B64 $src0)
+>;
+}
+
+def : GCNPat <
   (f16 (sint_to_fp i1:$src)),
   (V_CVT_F16_F32_e32 (V_CNDMASK_B32_e64 (i32 0), (i32 CONST.FP32_NEG_ONE), $src))
 >;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52518.166983.patch
Type: text/x-patch
Size: 1432 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180925/42e1efc5/attachment.bin>