[PATCH] D51276: [New PM][PassTiming] implement -time-passes for the new pass manager

Fedor Sergeev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 25 06:16:53 PDT 2018


fedor.sergeev marked 11 inline comments as done.
fedor.sergeev added inline comments.


================
Comment at: lib/Passes/StandardInstrumentations.cpp:111
     PassInstrumentationCallbacks &PIC) {
+  // print-before instrumentation
   if (llvm::shouldPrintBeforePass())
----------------
philip.pfaffe wrote:
> I don't think these comments here actually add anything.
if you grep the sources for the name of the option you will find this.
Other than that - yes, it does not add anything to the code readability.


Repository:
  rL LLVM

https://reviews.llvm.org/D51276





More information about the llvm-commits mailing list