[PATCH] D52454: Run VerifyDAGDiverence in debug only

[Alexander via Phabricator via llvm-commits]

alex-t added a comment.

TargetTransformInfo::hasBranchDivergence() only returns true only if the divergence makes sense for the given target.
So, the compile time should be only affected for such targets: AMDGPU, NVPTX etc.

On which target have you observed compile time increase? How much (% of the whole selection pass) was it affected?

I also initially planned to put the DAG verification under #ifdef NDEBUG.
My change was reviewed by Eli Friedman and he insisted on DAG verification for non-debug builds.
Maybe we should make him know that we changed this?


Repository:
  rL LLVM

https://reviews.llvm.org/D52454