[PATCH] D51524: [ARM64] [Windows] Handle funclets

[David Majnemer via Phabricator via llvm-commits]

majnemer added inline comments.


================
Comment at: lib/Target/AArch64/AArch64FrameLowering.cpp:1675-1679
+// Patch in zero for now.  Haven't encountered any problems yet.
+unsigned AArch64FrameLowering::getWinEHParentFrameOffset(
+    const MachineFunction &MF) const {
+  return 0;
+}
----------------
majnemer wrote:
> majnemer wrote:
> > This is used to populate `dispFrame` in `_s_HandlerType` IIRC. IIUC, you will have issues with certain catch handlers without this properly populated.
> Ah, it could be that `dispFrame` is not needed for ARM64. In that case, WinException.cpp should not call `getWinEHParentFrameOffset` and the `ParentFrameOffset` should not be emitted as it will add padding between the HandlerType elements.
Hmmm... So after a bunch of poking around with ARM64 CL.exe, I can confirm that they are allocating the `dispFrame` field and always fill it with zero!


Repository:
  rL LLVM

https://reviews.llvm.org/D51524