[PATCH] D51524: [ARM64] [Windows] Handle funclets

[David Majnemer via Phabricator via llvm-commits]

majnemer added inline comments.


================
Comment at: lib/Target/AArch64/AArch64FrameLowering.cpp:1638
+
+  // Create an UnwidHelp object.
+  int UnwindHelpFI =
----------------
UnwidHelp -> UnwindHelp?


================
Comment at: lib/Target/AArch64/AArch64FrameLowering.cpp:1639-1641
+  int UnwindHelpFI =
+      MFI.CreateStackObject(/*size*/8, /*alignment*/16, false);
+  EHInfo.UnwindHelpFrameIdx = UnwindHelpFI;
----------------
Should this be moved after the terminator check?


================
Comment at: lib/Target/AArch64/AArch64FrameLowering.cpp:1675-1679
+// Patch in zero for now.  Haven't encountered any problems yet.
+unsigned AArch64FrameLowering::getWinEHParentFrameOffset(
+    const MachineFunction &MF) const {
+  return 0;
+}
----------------
This is used to populate `dispFrame` in `_s_HandlerType` IIRC. IIUC, you will have issues with certain catch handlers without this properly populated.


Repository:
  rL LLVM

https://reviews.llvm.org/D51524