[PATCH] D51058: [zorg] Pass environment to getPollyBuildFactory and getAOSPBuildFactory

Galina via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 24 16:20:37 PDT 2018


gkistanova accepted this revision.
gkistanova added a comment.
This revision is now accepted and ready to land.

Hello Krzysztof,

Looks good, assuming you want to make builders use the locally set LD_LIBRARY_PATH env, and not push a particular value down to a builder.
Please feel free to commit once you will fix the nitpick.



================
Comment at: zorg/buildbot/builders/PollyBuilder.py:39
+                 }
+    if env is not None:
+        merged_env.update(env)  # Overwrite pre-set items with the given ones, so user can set anything.
----------------
You do not need to check for None here. You do not need to update if the given array is empty either.
```
    if env:
```
would do.


Repository:
  rL LLVM

https://reviews.llvm.org/D51058





More information about the llvm-commits mailing list