[PATCH] D52430: Introduce a flag to warn when IFUNC symbols are used with text relocations.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Can you update the commit message to make it clear that this patch adds a new command line flag? That is very important information that cannot be omit from the commit log.



================
Comment at: ELF/Options.td:352
+defm warn_ifunc_textrel: B<"warn-ifunc-textrel",
+   "Warn about using IFunc symbols with text relocations",
+   "Do not warn about using IFunc symbols with text relocations (default)">;
----------------
Isn't IFUNC all uppercase?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D52430